Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrectly aligned looktypes for 32x32 idle sprites when using protobuf #1019

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

nekiro
Copy link
Collaborator

@nekiro nekiro commented Jan 5, 2025

Description

Fix improperly positioned special looktypes that are 32x32 in idle, while 64x64 while walking.

Please test with .spr files, thanks.

Behavior

Actual

Are glitching

Expected

Should render properly

Fixes

Fix #914
Fix #828
Fix #961
Fix #966

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@nekiro nekiro changed the title fix: incorrectly aligned looktypes for 32x32 idle sprites fix: incorrectly aligned looktypes for 32x32 idle sprites when using protobuf Jan 5, 2025
Copy link
Collaborator

@kokekanon kokekanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test
with spr 8.60 tfs
with assets 13.10 tfs

Copy link

sonarqubecloud bot commented Jan 6, 2025

@leo36dff
Copy link

leo36dff commented Jan 6, 2025

Tested on 13.40 assets canary. 100%

@mehah mehah merged commit 52694e8 into main Jan 6, 2025
12 checks passed
@mehah mehah deleted the fix-protobuf-outfits branch January 6, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants